Repository navigation
Identify Verve cards before the broader Discover prefix - #429
Merged
Merged
Conversation
yezz123
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PaymentCardNumber currently identifies every card starting with 65 as Discover before it reaches the existing Verve range of 650002 through 650027. For example, the Luhn-valid number 6500020000000000 validates successfully but reports Discover. This also accepts 17-digit cards in that range even though the existing Verve rule permits only 16, 18 and 19 digits.
Check the existing Verve ranges before the broader Discover prefix. Add regression tests for both range boundaries at all three supported lengths, rejection of a Luhn-valid 17-digit number, and Discover prefixes immediately outside the Verve range.
Validation on Python 3.12.12:
This is a locally discovered bug. No live payment processing was tested. Other Python versions and the full repository typecheck were not run. The repository's frozen lockfile omits pandas, so pandas 3.0.6 and numpy 2.5.3 were installed separately to run the full suite.