fix(heroku): avoid duplicating /v1 in base_url#6142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes
HerokuProviderbase URL normalization when the configured Heroku inference URL already includes/v1.What Problem This Solves
HerokuProviderstripped trailing slashes and always appended/v1:That works for the default
https://us.inference.heroku.com, but it turns an already-normalized OpenAI-compatible endpoint into a malformed double-version path:Users may naturally pass a
/v1endpoint throughHerokuProvider(base_url=...)orHEROKU_INFERENCE_URL, since Heroku Managed Inference exposes OpenAI-compatible/v1/...API paths.Change
/v1only when the configured base URL does not already end with/v1./v1, with and without a trailing slash.Evidence
Before this change, local reproduction showed:
After this change, all supported inputs normalize to:
Reference: Heroku Managed Inference documents OpenAI-compatible
/v1API endpoints.Validation
uv run pytest tests/providers/test_heroku.py::test_heroku_provider_normalizes_base_urluv run ruff check pydantic_ai_slim/pydantic_ai/providers/heroku.py tests/providers/test_heroku.pyuv run ruff format --check pydantic_ai_slim/pydantic_ai/providers/heroku.py tests/providers/test_heroku.pygit diff --checkChecklist