Skip tool hooks for internal output tools#5128
Merged
Conversation
Tool hooks (validation and execution) were firing for internal output tools like `final_result`, leaving `after_tool_execute` free to return a `ToolReturn` that leaked through as `result.output` instead of the typed value. Exclude `kind='output'` tools from tool hook dispatch, matching how `WrapperToolset` and `prepare_tools` already exclude them. Closes #5111
github-actions
Bot
added
size: S
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Contributor
Docs Preview
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tool hooks (validation and execution) were firing for internal output tools like
final_result, leavingafter_tool_executefree to return aToolReturnthat leaked through asresult.outputinstead of the typed value.Exclude
kind='output'tools from tool hook dispatch, matching howWrapperToolsetandprepare_toolsalready exclude them. Follow-up PR #4859 will add dedicated output hooks for cases where users do want to wrap output tool calls.Checklist