Skip to content

fix: exclude validation error input from retry messages#4947

Merged
DouweM merged 1 commit intopydantic:mainfrom
navalprakhar:fix/strip-validation-error-input-from-retries
Apr 21, 2026
Merged

fix: exclude validation error input from retry messages#4947
DouweM merged 1 commit intopydantic:mainfrom
navalprakhar:fix/strip-validation-error-input-from-retries

Conversation

@navalprakhar
Copy link
Copy Markdown
Contributor

@navalprakhar navalprakhar commented Apr 2, 2026 •
edited
Loading

Pre-Review Checklist

  • Any AI generated code has been reviewed line-by-line by the human PR author, who stands by it.
  • No breaking changes in accordance with the version policy.
  • Linting and type checking pass per make format and make typecheck.
  • PR title is fit for the release changelog.

Pre-Merge Checklist

  • New tests for any fix or new behavior, maintaining 100% coverage.
  • Updated documentation for new features and behaviors, including docstrings for API docs.

@github-actions github-actions Bot added size: S Small PR (≤100 weighted lines) bug Report that something isn't working, or PR implementing a fix labels Apr 2, 2026
devin-ai-integration[bot]
devin-ai-integration Bot reviewed Apr 2, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 1 additional finding.

Open in Devin Review

@navalprakhar navalprakhar mentioned this pull request Apr 8, 2026
Closed
2 tasks
DouweM
DouweM reviewed Apr 10, 2026
View reviewed changes
Comment thread tests/test_agent.py
@DouweM DouweM self-assigned this Apr 10, 2026
@navalprakhar navalprakhar force-pushed the fix/strip-validation-error-input-from-retries branch from 58622b1 to c220d48 Compare April 10, 2026 18:11
devin-ai-integration[bot]

This comment was marked as resolved.

Sign in to view

@navalprakhar navalprakhar force-pushed the fix/strip-validation-error-input-from-retries branch from c220d48 to fa1d0f0 Compare April 10, 2026 18:24
devin-ai-integration[bot]

This comment was marked as resolved.

Sign in to view

@navalprakhar navalprakhar force-pushed the fix/strip-validation-error-input-from-retries branch from fa1d0f0 to 84c2cee Compare April 10, 2026 18:31
@navalprakhar navalprakhar force-pushed the fix/strip-validation-error-input-from-retries branch from 84c2cee to be35078 Compare April 10, 2026 18:33
@navalprakhar navalprakhar requested a review from DouweM April 10, 2026 18:43
@navalprakhar
Copy link
Copy Markdown
Contributor Author

navalprakhar commented Apr 20, 2026

@DouweM any feedback on this one?

@DouweM DouweM merged commit 3344a03 into pydantic:main Apr 21, 2026
50 checks passed
@DouweM
Copy link
Copy Markdown
Collaborator

DouweM commented Apr 21, 2026

@navalprakhar Love it, thanks!

@sfrey1 sfrey1 mentioned this pull request Apr 23, 2026
Closed
2 tasks
@DouweM DouweM mentioned this pull request Apr 23, 2026
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devin-ai-integration devin-ai-integration[bot] devin-ai-integration[bot] left review comments

@DouweM DouweM Awaiting requested review from DouweM

Assignees

@DouweM DouweM

Labels

bug Report that something isn't working, or PR implementing a fix size: S Small PR (≤100 weighted lines)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

NativeOutput retries include full ValidationError input causing token bloat and noisy correction signal

2 participants

@navalprakhar @DouweM