Skip to content

🐛 Fix TypeError on mixed discriminated unions#6282

Merged
lig merged 1 commit intomainfrom
lig/6213-v20b3-discriminator-on-union-of-models-in-rootmodel-yields-typeerror
Jun 28, 2023
Merged

🐛 Fix TypeError on mixed discriminated unions#6282
lig merged 1 commit intomainfrom
lig/6213-v20b3-discriminator-on-union-of-models-in-rootmodel-yields-typeerror

Conversation

@lig
Copy link
Copy Markdown
Contributor

@lig lig commented Jun 28, 2023

Change Summary

Added support for definition-ref in discriminated unions.

Related issue number

Fixes #6213

Checklist

  • Unit tests for the changes exist
  • Tests pass on CI and coverage remains at 100%
  • Documentation reflects the changes where applicable
  • changes/<pull request or issue id>-<github username>.md file added describing change
    (see changes/README.md for details)
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer: @adriangb

@cloudflare-workers-and-pages
Copy link
Copy Markdown

@lig lig marked this pull request as ready for review June 28, 2023 12:08
@lig
Copy link
Copy Markdown
Contributor Author

lig commented Jun 28, 2023

please review

@lig lig merged commit 82effa3 into main Jun 28, 2023
@lig lig deleted the lig/6213-v20b3-discriminator-on-union-of-models-in-rootmodel-yields-typeerror branch June 28, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

v2.0b3: Discriminator on union of models in RootModel yields TypeError

2 participants