Skip to content

🗑️ Deprecate Color and PaymentCardNumber#6003

Merged
Kludex merged 7 commits intomainfrom
deprecation/color-payment
Jun 5, 2023
Merged

🗑️ Deprecate Color and PaymentCardNumber#6003
Kludex merged 7 commits intomainfrom
deprecation/color-payment

Conversation

@Kludex
Copy link
Copy Markdown
Member

@Kludex Kludex commented Jun 5, 2023 •
edited by pydantic-hooky Bot
Loading

Change Summary

  • Deprecate Color and PaymentCardNumber.
  • Delete documentation for both - It will be readded from pydantic-extra-types side.

Selected Reviewer: @lig

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented Jun 5, 2023 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3254e3c
Status: ✅  Deploy successful!
Preview URL: https://17587398.pydantic-docs2.pages.dev
Branch Preview URL: https://deprecation-color-payment.pydantic-docs2.pages.dev

View logs

@Kludex Kludex requested a review from hramezani June 5, 2023 10:59
@Kludex
Copy link
Copy Markdown
Member Author

Kludex commented Jun 5, 2023

please review

@Kludex
Copy link
Copy Markdown
Member Author

Kludex commented Jun 5, 2023

Actually... Sorry reviewers. I want to include pydantic-extra-types documentation here as well. 🤔

Wait a bit.

@Kludex Kludex marked this pull request as draft June 5, 2023 11:05
@Kludex Kludex marked this pull request as ready for review June 5, 2023 12:14
@Kludex
Copy link
Copy Markdown
Member Author

Kludex commented Jun 5, 2023

please review

hramezani
hramezani reviewed Jun 5, 2023
View reviewed changes
Comment thread pydantic/types.py Outdated
yezz123
yezz123 approved these changes Jun 5, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@yezz123 yezz123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Kludex and others added 2 commits June 5, 2023 14:22
@Kludex Kludex enabled auto-merge (squash) June 5, 2023 12:27
@Kludex Kludex merged commit 3c4fee5 into main Jun 5, 2023
@Kludex Kludex deleted the deprecation/color-payment branch June 5, 2023 12:33
@yezz123 yezz123 mentioned this pull request Jun 5, 2023
Closed
@svlandeg svlandeg mentioned this pull request Mar 13, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hramezani hramezani hramezani approved these changes

+1 more reviewer

@yezz123 yezz123 yezz123 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@lig lig

Labels

ready for review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Kludex @hramezani @yezz123 @lig