Skip to content

Allow self to be used as a parameter with @validate_call - #13773

Merged
Viicos merged 1 commit into
mainfrom
vp/validate-call-self
Sep 7, 2026
Merged

Viicos merged 1 commit into
mainfrom
vp/validate-call-self

Conversation

@Viicos

@Viicos Viicos commented Sep 7, 2026

Copy link
Copy Markdown
Member

Change Summary

Fixes #13771.

Related issue number

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@Viicos Viicos added the relnotes-fix Used for bugfixes. label Sep 7, 2026
@Viicos
Viicos enabled auto-merge (squash) September 7, 2026 13:06
@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 9ad3810
Status: ✅  Deploy successful!
Preview URL: https://fcf3045b.pydantic-docs.pages.dev
Branch Preview URL: https://vp-validate-call-self.pydantic-docs.pages.dev

View logs

@Viicos
Viicos merged commit 2261ae1 into main Sep 7, 2026
88 checks passed
@Viicos
Viicos deleted the vp/validate-call-self branch September 7, 2026 13:15
@codspeed

codspeed Bot commented Sep 7, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 5.01%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

❌ 1 regressed benchmark
✅ 215 untouched benchmarks
⏩ 163 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Benchmark BASE HEAD Efficiency
❌ test_list_of_ints_core_json 734.2 µs 772.9 µs -5.01%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing vp/validate-call-self (9ad3810) with main (0f0798b)

Open in CodSpeed

Footnotes

  1. 163 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  pydantic/_internal
  _validate_call.py
Project Total  

This report was generated by python-coverage-comment-action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

relnotes-fix Used for bugfixes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

validate_call cannot call a function with a keyword parameter named self

1 participant