Handle AttributeError subclasses with from_attributes#13096
Merged
Conversation
Viicos
added
relnotes-fix
Deploying pydantic-docs with
|
| Latest commit: |
d80a022
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://57a888b2.pydantic-docs.pages.dev |
| Branch Preview URL: | https://vp-from-attributes-attribute.pydantic-docs.pages.dev |
Merging this PR will improve performance by 6.66%
|
| Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|
| ⚡ | test_field_function_validator |
343.3 µs | 321.8 µs | +6.66% |
Comparing vp/from-attributes-attributeerror-sub (d80a022) with main (a6bf50b)
Contributor
Coverage report
This PR does not seem to contain any modification to coverable code. |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
davidhewitt
approved these changes
Apr 20, 2026
Viicos
added a commit
that referenced
this pull request
Apr 20, 2026
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
Fixes #13092
Related issue number
Checklist