Skip to content

Add basic benchmarks for model equality#13061

Merged
Viicos merged 1 commit intomainfrom
vp/model-eq-basic-benchmarks
Apr 10, 2026
Merged

Add basic benchmarks for model equality#13061
Viicos merged 1 commit intomainfrom
vp/model-eq-basic-benchmarks

Conversation

@Viicos
Copy link
Copy Markdown
Member

@Viicos Viicos commented Apr 10, 2026

Change Summary

Related issue number

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@Viicos Viicos added the relnotes-ignore Omit this PR from the release notes. label Apr 10, 2026
@cloudflare-workers-and-pages
Copy link
Copy Markdown

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Apr 10, 2026

Merging this PR will degrade performance by 6.46%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

❌ 1 regressed benchmark
✅ 211 untouched benchmarks
🆕 3 new benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Benchmark BASE HEAD Efficiency
test_uuid_from_uuid_core 15.4 µs 16.4 µs -6.46%
🆕 test_model_eq_extra_forbid N/A 37.1 µs N/A
🆕 test_model_eq_extra_allow_extra N/A 32.7 µs N/A
🆕 test_model_eq_extra_allow_no_extra N/A 31.4 µs N/A

Comparing vp/model-eq-basic-benchmarks (9e64d8f) with main (d17d71e)

Open in CodSpeed

@github-actions
Copy link
Copy Markdown
Contributor

Coverage report

This PR does not seem to contain any modification to coverable code.

@Viicos Viicos merged commit 671c9b0 into main Apr 10, 2026
83 of 84 checks passed
@Viicos Viicos deleted the vp/model-eq-basic-benchmarks branch April 10, 2026 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

relnotes-ignore Omit this PR from the release notes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants