Skip to content

Add regression test for MISSING sentinel serialization with subclasses#13048

Merged
Viicos merged 1 commit intomainfrom
vp/missing-sentinel-child-ser-regression-test
Apr 9, 2026
Merged

Add regression test for MISSING sentinel serialization with subclasses#13048
Viicos merged 1 commit intomainfrom
vp/missing-sentinel-child-ser-regression-test

Conversation

@Viicos
Copy link
Copy Markdown
Member

@Viicos Viicos commented Apr 7, 2026

Change Summary

Fixes #13001.

Related issue number

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@Viicos Viicos requested a review from hramezani April 7, 2026 09:22
@Viicos Viicos added the relnotes-ignore Omit this PR from the release notes. label Apr 7, 2026
@cloudflare-workers-and-pages
Copy link
Copy Markdown

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Apr 7, 2026

Merging this PR will not alter performance

✅ 212 untouched benchmarks


Comparing vp/missing-sentinel-child-ser-regression-test (1917212) with main (82c15f0)

Open in CodSpeed

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 7, 2026

Coverage report

This PR does not seem to contain any modification to coverable code.

@Viicos Viicos merged commit 2a806ad into main Apr 9, 2026
84 checks passed
@Viicos Viicos deleted the vp/missing-sentinel-child-ser-regression-test branch April 9, 2026 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

relnotes-ignore Omit this PR from the release notes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Subclass Serialization Includes Child Fields with MISSING Sentinel

2 participants