Remove some XPASS markers for PyPy 3.11 #12952
Closed
galuszkak wants to merge 2 commits intopydantic:mainfrom
Closed
Remove some XPASS markers for PyPy 3.11 #12952galuszkak wants to merge 2 commits intopydantic:mainfrom
galuszkak wants to merge 2 commits intopydantic:mainfrom
Conversation
Contributor
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
Contributor
Author
|
I think this is ready - I'm not sure why those slots are uninitialized - but this is the only thing that I could figure out while trying to understand why only in pypy this is happening with LLM - please review . |
5 tasks
Member
|
Handled in #12954. I don't think the LLM fix is correct because I can reproduce the segmentation fault with it. |
Contributor
Author
|
Interesting! @Viicos - why did then it pass in CI and locally for me? Looks like something non deterministic then... I will create issue to track this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
While working on #12951 - I had some tests xfail passing - when comparing logs between main and my PR I realized build:
mainbranch usedpypy3.11-7.3.20- log https://github.com/pydantic/pydantic/actions/runs/23256413601/job/67612512011pypy3.11-7.3.21- log https://github.com/pydantic/pydantic/actions/runs/23416755262/job/68113631533?pr=12951My hypothesis is that some of those tests are passing now because of new pypy3 version.
Checklist
Selected Reviewer: @Viicos