Skip to content

Check for PlaceholderNode in Mypy plugin#12929

Merged
Viicos merged 1 commit intomainfrom
vp/mypy-plugin-placeholder
Mar 17, 2026
Merged

Check for PlaceholderNode in Mypy plugin#12929
Viicos merged 1 commit intomainfrom
vp/mypy-plugin-placeholder

Conversation

@Viicos
Copy link
Copy Markdown
Member

@Viicos Viicos commented Mar 17, 2026

Change Summary

Fixes #12928.

Related issue number

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@Viicos Viicos added the relnotes-fix Used for bugfixes. label Mar 17, 2026
@cloudflare-workers-and-pages
Copy link
Copy Markdown

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: ffa4f75
Status: ✅  Deploy successful!
Preview URL: https://a6e3e698.pydantic-docs.pages.dev
Branch Preview URL: https://vp-mypy-plugin-placeholder.pydantic-docs.pages.dev

View logs

@Viicos Viicos enabled auto-merge (squash) March 17, 2026 10:49
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Mar 17, 2026

Merging this PR will not alter performance

✅ 212 untouched benchmarks


Comparing vp/mypy-plugin-placeholder (ffa4f75) with main (fbf9c6e)

Open in CodSpeed

@Viicos Viicos merged commit 772448e into main Mar 17, 2026
82 checks passed
@Viicos Viicos deleted the vp/mypy-plugin-placeholder branch March 17, 2026 10:55
@github-actions
Copy link
Copy Markdown
Contributor

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  pydantic
  mypy.py
Project Total  

This report was generated by python-coverage-comment-action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

relnotes-fix Used for bugfixes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

mypy plugin crash with NewType attribute override

2 participants