Skip to content

Fix version-added directive for polymorphic_serialization#12910

Merged
Viicos merged 1 commit intopydantic:mainfrom
rmorshea:patch-1
Mar 11, 2026
Merged

Fix version-added directive for polymorphic_serialization#12910
Viicos merged 1 commit intopydantic:mainfrom
rmorshea:patch-1

Conversation

@rmorshea
Copy link
Copy Markdown
Contributor

@rmorshea rmorshea commented Mar 11, 2026 •
edited by pydantic-hooky Bot
Loading

Updates the documentation to report polymorphic_serialization as being added in v2.13.

From what I can tell this feature is not available in any 2.12 release. The last 2.12 release was in Nov of 2025 but the feature was only merged a few weeks ago.

Change Summary

Related issue number

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer: @Viicos

@rmorshea
Update docs to say polymorphic_serialization added in v2.13
0368a4b 
From what I can tell this feature has not been released yet in v2.12.
@github-actions github-actions Bot added the relnotes-fix Used for bugfixes. label Mar 11, 2026
@rmorshea
Copy link
Copy Markdown
Contributor Author

rmorshea commented Mar 11, 2026

please review

@Viicos Viicos changed the title Update docs to say polymorphic_serialization added in v2.13 Fix version-added directive for polymorphic_serialization Mar 11, 2026
@Viicos Viicos added relnotes-ignore Omit this PR from the release notes. and removed ready for review relnotes-fix Used for bugfixes. labels Mar 11, 2026
Viicos
Viicos approved these changes Mar 11, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@Viicos Viicos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@Viicos Viicos enabled auto-merge (squash) March 11, 2026 16:12
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Mar 11, 2026

Merging this PR will degrade performance by 5.61%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

❌ 1 regressed benchmark
✅ 211 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Benchmark BASE HEAD Efficiency
❌ test_list_of_strs_json_uncached 410.9 µs 435.4 µs -5.61%

Comparing rmorshea:patch-1 (0368a4b) with main (938e81d)

Open in CodSpeed

@Viicos Viicos merged commit f2bc256 into pydantic:main Mar 11, 2026
80 of 81 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 11, 2026

Coverage report

This PR does not seem to contain any modification to coverable code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Viicos Viicos Viicos approved these changes

Assignees

@Viicos Viicos

Labels

relnotes-ignore Omit this PR from the release notes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rmorshea @Viicos