Skip to content

Respect extras_schema when only extra_fields_behavior is set on the config in JSON Schema generation for typed dictionaries#12810

Merged
Viicos merged 1 commit intomainfrom
vp/12809
Mar 2, 2026
Merged

Respect extras_schema when only extra_fields_behavior is set on the config in JSON Schema generation for typed dictionaries#12810
Viicos merged 1 commit intomainfrom
vp/12809

Conversation

@Viicos
Copy link
Copy Markdown
Member

@Viicos Viicos commented Feb 17, 2026

Fixes #12809.

Change Summary

Related issue number

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

…he config in JSON Schema generation for typed dictionaries
@Viicos Viicos added the relnotes-fix Used for bugfixes. label Feb 17, 2026
@cloudflare-workers-and-pages
Copy link
Copy Markdown

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: b056562
Status: ✅  Deploy successful!
Preview URL: https://9ad9b226.pydantic-docs.pages.dev
Branch Preview URL: https://vp-12809.pydantic-docs.pages.dev

View logs

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Feb 17, 2026

Merging this PR will not alter performance

✅ 212 untouched benchmarks


Comparing vp/12809 (b056562) with main (26da044)

Open in CodSpeed

@github-actions
Copy link
Copy Markdown
Contributor

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  pydantic
  json_schema.py
Project Total  

This report was generated by python-coverage-comment-action

@Viicos Viicos merged commit a2fcb8b into main Mar 2, 2026
70 checks passed
@Viicos Viicos deleted the vp/12809 branch March 2, 2026 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

relnotes-fix Used for bugfixes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

typed_dict_schema JSON schema ignores extras_schema when extra_fields_behavior is set via config

2 participants