Skip to content

Migrate pydantic-core CI#12752

Merged
Viicos merged 22 commits intomainfrom
vp/migrate-core-cig
Feb 19, 2026
Merged

Migrate pydantic-core CI#12752
Viicos merged 22 commits intomainfrom
vp/migrate-core-cig

Conversation

@Viicos
Copy link
Copy Markdown
Member

@Viicos Viicos commented Jan 28, 2026

Change Summary

Migrate the pydantic-core CI into the main ci.yml workflow. This is done relatively smoothly, but as part of this, I had to:

Related issue number

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@github-actions github-actions Bot added the relnotes-fix Used for bugfixes. label Jan 28, 2026
@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented Jan 28, 2026

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 062ac9a
Status: ✅  Deploy successful!
Preview URL: https://562ae5c5.pydantic-docs.pages.dev
Branch Preview URL: https://vp-migrate-core-cig.pydantic-docs.pages.dev

View logs

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Jan 28, 2026

Merging this PR will not alter performance

✅ 212 untouched benchmarks


Comparing vp/migrate-core-cig (062ac9a) with main (a910cae)

Open in CodSpeed

@github-actions
Copy link
Copy Markdown
Contributor

Coverage report

This PR does not seem to contain any modification to coverable code.

@Viicos Viicos force-pushed the vp/migrate-core-cig branch from 334f767 to 63524fd Compare January 28, 2026 15:49
@Viicos Viicos added full build Triggers CI to do a full build and removed relnotes-fix Used for bugfixes. labels Jan 28, 2026
@Viicos Viicos closed this Jan 28, 2026
@Viicos Viicos reopened this Jan 28, 2026
Comment thread .github/workflows/ci.yml Outdated
Comment thread .github/actions/core-build-pgo-wheel/action.yml Outdated
@Viicos Viicos force-pushed the vp/migrate-core-cig branch from 1b30d84 to 4536b01 Compare February 2, 2026 18:50
@Viicos Viicos force-pushed the vp/migrate-core-cig branch from 5831446 to 9c83432 Compare February 3, 2026 12:39
@Viicos Viicos force-pushed the vp/migrate-core-cig branch from 9c83432 to 9187df2 Compare February 3, 2026 14:19
As per rust-lang/rust#53667, 1.88
is required for some if let statements.
Copy link
Copy Markdown
Collaborator

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this might help

Comment thread .github/workflows/ci.yml Outdated
Comment thread .github/workflows/ci.yml Outdated
@Viicos Viicos force-pushed the vp/migrate-core-cig branch from 2f26353 to 91cb323 Compare February 11, 2026 14:55
@Viicos Viicos force-pushed the vp/migrate-core-cig branch from 4b73b9c to 69eb8fd Compare February 11, 2026 17:50
@Viicos Viicos force-pushed the vp/migrate-core-cig branch from 3b78d82 to c4c8807 Compare February 11, 2026 21:47
@Viicos Viicos marked this pull request as ready for review February 12, 2026 11:59
@Viicos Viicos added needs-blogpost-entry This PR needs to be documented in the release notes blog post relnotes-change Used for changes to existing functionality which don't have a better categorization. labels Feb 12, 2026
@Viicos Viicos merged commit e247030 into main Feb 19, 2026
129 checks passed
@Viicos Viicos deleted the vp/migrate-core-cig branch February 19, 2026 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

full build Triggers CI to do a full build needs-blogpost-entry This PR needs to be documented in the release notes blog post relnotes-change Used for changes to existing functionality which don't have a better categorization.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants