-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Add polymorphic_serialization option
#12518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
0c762dd
add `polymorphic_serialization` flag to `pydantic-core`
davidhewitt a88411f
implement at the `pydantic` level
davidhewitt 290f788
override `pydantic-core` dependency for testing
davidhewitt 2cf80df
fixup docs and tests
davidhewitt 293129a
remove debug prints in polymorphism_trampoline
davidhewitt 3f56f5d
clarify interaction with stdlib dataclasses
davidhewitt c96c8ed
Lint
Viicos 5bf3d5a
Merge branch 'main' into dh/polymorphic-serialization
davidhewitt 3e0b894
remove debug prints
davidhewitt 0f41f58
move tests for polymorphic_serialization from core to pydantic
davidhewitt 320e5d3
Merge branch 'main' into dh/polymorphic-serialization
davidhewitt 805b36f
clarify stdlib support
davidhewitt 7f9f3dd
Merge branch 'main' into dh/polymorphic-serialization
davidhewitt 464705c
Doc updates
Viicos 7544a29
Feedback
Viicos 20bdba7
Merge branch 'main' into dh/polymorphic-serialization
Viicos 3917617
lint
Viicos 16aa024
fix pyproject
Viicos 6a04e9f
coverage
Viicos File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How hard would it be to fallback to inference (as
serialize_as_anydoes) in this case? I'm worried we recommend switching fromserialize_as_anytopolymorphic_serializationbut then users discover that it's "less powerful" in this case.I guess it's a trade-off between not having it supported for now (and being able to implement it properly later), and having the limited inference behavior now (and users could as such rely on it) but such behavior changing when we implement it properly (and so is a behavior change for users already relying on it).