Fix url python serialization (#11331)

sydney-runkle · web-flow · commit 416082625aed · 2025-01-23T12:33:17.000-05:00
diff --git a/pydantic/networks.py b/pydantic/networks.py
@@ -290,12 +290,14 @@ def build(
         )
 
     @classmethod
-    def serialize_url(cls, url: Any) -> str:
+    def serialize_url(cls, url: Any, info: core_schema.SerializationInfo) -> str | Self:
         if not isinstance(url, cls):
             raise PydanticSerializationUnexpectedValue(
                 f"Expected `{cls}` but got `{type(url)}` with value `'{url}'` - serialized value may not be as expected."
             )
-        return str(url)
+        if info.mode == 'json':
+            return str(url)
+        return url
 
     @classmethod
     def __get_pydantic_core_schema__(
@@ -314,7 +316,9 @@ def wrap_val(v, h):
         return core_schema.no_info_wrap_validator_function(
             wrap_val,
             schema=core_schema.url_schema(**cls._constraints.defined_constraints),
-            serialization=core_schema.plain_serializer_function_ser_schema(cls.serialize_url),
+            serialization=core_schema.plain_serializer_function_ser_schema(
+                cls.serialize_url, info_arg=True, when_used='always'
+            ),
         )
 
     @classmethod
@@ -465,12 +469,14 @@ def build(
         )
 
     @classmethod
-    def serialize_url(cls, url: Any) -> str:
+    def serialize_url(cls, url: Any, info: core_schema.SerializationInfo) -> str | Self:
         if not isinstance(url, cls):
             raise PydanticSerializationUnexpectedValue(
                 f"Expected `{cls}` but got `{type(url)}` with value `'{url}'` - serialized value may not be as expected."
             )
-        return str(url)
+        if info.mode == 'json':
+            return str(url)
+        return url
 
     @classmethod
     def __get_pydantic_core_schema__(
@@ -489,7 +495,9 @@ def wrap_val(v, h):
         return core_schema.no_info_wrap_validator_function(
             wrap_val,
             schema=core_schema.multi_host_url_schema(**cls._constraints.defined_constraints),
-            serialization=core_schema.plain_serializer_function_ser_schema(cls.serialize_url),
+            serialization=core_schema.plain_serializer_function_ser_schema(
+                cls.serialize_url, info_arg=True, when_used='always'
+            ),
         )
 
     @classmethod
diff --git a/tests/test_networks.py b/tests/test_networks.py
@@ -1189,3 +1189,15 @@ def test_unexpected_ser() -> None:
         match="Expected `<class 'pydantic.networks.HttpUrl'>` but got `<class 'str'>` with value `'http://example.com'`",
     ):
         ta.dump_python('http://example.com', warnings='error')
+
+
+def test_url_ser() -> None:
+    ta = TypeAdapter(HttpUrl)
+    assert ta.dump_python(HttpUrl('http://example.com')) == HttpUrl('http://example.com')
+    assert ta.dump_json(HttpUrl('http://example.com')) == b'"http://example.com/"'
+
+
+def test_url_ser_as_any() -> None:
+    ta = TypeAdapter(Any)
+    assert ta.dump_python(HttpUrl('http://example.com')) == HttpUrl('http://example.com')
+    assert ta.dump_json(HttpUrl('http://example.com')) == b'"http://example.com/"'
