Handle cyclic references in exceptions#1284
Merged
alexmojaki merged 3 commits intomainfrom Jul 31, 2025
Merged
Conversation
Deploying logfire-docs with
|
| Latest commit: |
25d78cd
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://bfb48297.logfire-docs.pages.dev |
| Branch Preview URL: | https://alex-exc-cycles.logfire-docs.pages.dev |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds handling for cyclic references in exception chains to prevent infinite recursion when canonicalizing exception tracebacks. The implementation tracks previously seen exceptions using their object IDs and displays <repeated exception> for cycles.
- Adds a
seenparameter to track visited exceptions by ID - Implements cycle detection before processing exception causes, contexts, and groups
- Adds comprehensive test coverage for cyclic exception scenarios
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| logfire/_internal/utils.py | Implements cycle detection logic in canonicalize_exception_traceback function |
| tests/test_canonicalize_exception.py | Adds test cases for cyclic exception cause and exception group scenarios |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1279