Switch httpcore2 from certifi to truststore for default SSL verification#1002
Merged
Conversation
…ication Mirrors #209, which only switched httpx2. httpcore2 still declared `certifi` directly and loaded it in `default_ssl_context()`, so it was installed and imported even though httpx2 always passes its own truststore context down. `certifi` now remains only as a transitive test dependency of `requests`.
Merging this PR will not alter performance
Comparing 
Footnotes
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 635c68bdbb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Bare `truststore.SSLContext` ignores the OpenSSL CA env overrides, so direct httpcore2 users relying on them for a corporate/private CA would lose verification. Mirror the `httpx2.create_ssl_context()` fallback.
Match httpx2's `# pragma: no cover` precedent for the env-override paths instead of testing them.
Kludex
enabled auto-merge (squash)
June 1, 2026 10:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#209 switched
httpx2totruststorebut lefthttpcore2declaringcertifidirectly and loadingcertifi.where()indefault_ssl_context(). Sincehttpx2always builds its own truststore context and passes it down,certifiwas only ever exercised whenhttpcore2is used directly withssl_context=None- but it was still installed and imported regardless.This mirrors #209 at the
httpcore2layer.certifinow survives only as a transitive test dependency ofrequests, no longer pulled in by either package.mypy, ruff, and the full
httpcore2test suite (223 tests) pass.AI Disclaimer
This PR was developed with the assistance of either Claude or Codex. I've reviewed and verified the changes.