Consolidate StaticFilter and ArrayHashSet#44
Merged
adriangb merged 2 commits intopydantic:refactor-in-listfrom Nov 17, 2025
Merged
Consolidate StaticFilter and ArrayHashSet#44adriangb merged 2 commits intopydantic:refactor-in-listfrom
adriangb merged 2 commits intopydantic:refactor-in-listfrom
Conversation
alamb
commented
Nov 17, 2025
| } | ||
|
|
||
| #[derive(Debug, Clone)] | ||
| pub(crate) struct ArrayHashSet { |
Author
There was a problem hiding this comment.
this state is logically part of StaticFilter -- the map contains the contents of the ArrayRef
| fn contains( | ||
| &self, | ||
| v: &dyn Array, | ||
| in_array: &dyn Array, |
Author
There was a problem hiding this comment.
it was strange to always pass in in_array here as it is always StaticFilter::array
| /// are nulls present or there are more than the configured number of | ||
| /// elements. | ||
| /// | ||
| /// Note: This is split into a separate function as higher-rank trait bounds currently |
This was referenced Nov 17, 2025
adriangb
pushed a commit
that referenced
this pull request
Nov 18, 2025
* Consolidate StaticFilter and ArrayHashSet * Fix docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While reviewing apache#18449 I found it strange that the ArrayHashSet relied on fields o StaticFilter that had to be passed in correctly.
Consolidating them I think makes the code easier to read