Merged
Conversation
alamb
commented
Apr 2, 2025
| insta::assert_snapshot!( | ||
| OptimizationTest::new(plan, FilterPushdown{}), | ||
| @r" | ||
| OptimizationTest: |
Author
There was a problem hiding this comment.
The idea is to be able to express tests like this -- I will add a few more to show what is going on
alamb
force-pushed
the
alamb/topk-filter-tests
branch
from
657187c to
d89a29e
Compare
alamb
commented
Apr 2, 2025
| output: | ||
| Ok: | ||
| - FilterExec: b@1 = bar | ||
| - FilterExec: a@0 = foo AND b@1 = bar |
Author
There was a problem hiding this comment.
here is some interesting behavior -- the filters get pushed down but the originals are left
Member
|
Great, will merge and fix / get passing / resolve conflicts! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR targets a PR in DataFusion
It adds basic tests for the filter pushdown physical optimizer introduced in that PR
It is largely based on the structure in influxdb_iox's query engine
https://github.com/influxdata/influxdb3_core/blob/26a30bf8d6e2b6b3f1dd905c4ec27e3db6e20d5f/iox_query/src/physical_optimizer/predicate_pushdown.rs#L24
I believe @crepereum and @NGA-TRAN were largely responsible for this code originally. To be clear, I am trying to give credit where it is due :) Any faults of this port are my own, not thiers