You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit fb6b453
Browse filesBrowse the repository at this point in the historyBrowse files
prototype: migrate the sink family (DataSink hook + 3 file sinks) onto the proto hook (apache#22419)
Mirrors the scan side: DataSink::try_to_proto hook on the trait, DataSinkExec
rides the ExecutionPlan hook and delegates to its sink (encoding input +
sort_order via the ctx, since a sink carries no child exprs). FileSinkConfig
serde ported into datafusion-datasource (file_sink_config/proto.rs), reusing the
scan side's PartitionedFile helpers; no codec needed.
CsvSink/JsonSink/ParquetSink each implement DataSink::try_to_proto + an inherent
try_from_proto. The central try_from_data_sink_exec, the DataSinkExec encode arm,
the try_into_*_sink_physical_plan decoders, and the colliding
TryFromProto<&protobuf::*Sink> for *Sink decode impls are all deleted; the 3 sink
decode arms repoint to <Fmt>Sink::try_from_proto. roundtrip_{csv,json,parquet}_sink
stay green (193 tests).
Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
Claude-Session: https://claude.ai/code/session_01SfBPC2yYCwHUn4V8pQCVj3
0 commit comments