Repository navigation
Commit f7ab87a
refactor(proto): remove the FromProto / TryFromProto workaround
apache#21929 introduced these traits so the `datafusion-proto-models` extraction
could land without simultaneously relocating ~39 conversions, and flagged them
there as "a known workaround, not the end state". Every one of those
conversions now lives in a crate that owns one side of it, as a plain `From` /
`TryFrom`, so the traits and `convert_required_proto!` have no implementors and
no callers.
Neither trait has ever shipped in a release, so this removes them outright
rather than deprecating: there is nothing for downstream users to migrate off.
Doing it before 55.0.0 keeps the workaround out of the released API entirely.
Closes apache#24019.
Co-Authored-By: Claude Opus 5 <[email protected]>1 parent 4d91570 commit f7ab87a
4 files changed
Lines changed: 2 additions & 67 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
498 | 498 | | |
499 | 499 | | |
500 | 500 | | |
501 | | - | |
502 | | - | |
| 501 | + | |
| 502 | + | |
503 | 503 | | |
504 | 504 | | |
505 | 505 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
26 | 26 | | |
27 | 27 | | |
28 | 28 | | |
29 | | - | |
30 | | - | |
31 | | - | |
32 | | - | |
33 | | - | |
34 | | - | |
35 | | - | |
36 | | - | |
37 | | - | |
38 | | - | |
39 | | - | |
40 | | - | |
41 | | - | |
42 | | - | |
43 | | - | |
44 | | - | |
45 | | - | |
46 | | - | |
47 | 29 | | |
48 | 30 | | |
49 | 31 | | |
| |||
This file was deleted.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
123 | 123 | | |
124 | 124 | | |
125 | 125 | | |
126 | | - | |
127 | 126 | | |
128 | 127 | | |
129 | 128 | | |
130 | | - | |
131 | | - | |
132 | 129 | | |
133 | 130 | | |
134 | 131 | | |
| |||
0 commit comments