Repository navigation
Commit e93196a
docs: fix stale
The comment on the `SQLDataType::Timestamp` arm in `planner.rs` promises
`Timestamp<TimeUnit, Some(Time Zone)>`, but the expression it describes is an
`Option<String>` that is `None` by default. That comment went stale in
apache#18359, which changed
`datafusion.execution.time_zone` from `String` to `Option<String>` and dropped
the `Some(...)` wrapper without touching the two lines above it. Correct the
comment; the behavior itself is under discussion in
apache#25166 and is left unchanged.
`docs/source/user-guide/sql/data_types.md` had no row for
`TIMESTAMP WITH TIME ZONE` / `TIMESTAMPTZ` at all. Add one, along with the
optional `(p)` precision that both it and `TIMESTAMP` accept, and note that the
timezone component comes from `datafusion.execution.time_zone`, which is unset
by default.
Co-Authored-By: Claude Opus 5 <[email protected]>TIMESTAMP WITH TIME ZONE comment, document the mapping1 parent e640ae0 commit e93196a
2 files changed
Lines changed: 27 additions & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
775 | 775 | | |
776 | 776 | | |
777 | 777 | | |
778 | | - | |
| 778 | + | |
| 779 | + | |
| 780 | + | |
| 781 | + | |
| 782 | + | |
| 783 | + | |
| 784 | + | |
779 | 785 | | |
780 | 786 | | |
781 | 787 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
105 | 105 | | |
106 | 106 | | |
107 | 107 | | |
108 | | - | |
109 | | - | |
110 | | - | |
111 | | - | |
112 | | - | |
113 | | - | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
114 | 128 | | |
115 | 129 | | |
116 | 130 | | |
| |||
0 commit comments