Repository navigation
Commit 8d4ecbf
chore(proto): remove transient FromProto/TryFromProto traits
After C3-C7 relocated all of the orphan-rule-violating conversion impls
into the crates that own their target types, the `FromProto` /
`TryFromProto` traits in `datafusion-proto::convert` and the
`convert_required_proto!` macro have no remaining external uses. Delete
them.
Two cleanups remain in datafusion-proto's source tree, neither of which
warrant a public trait:
- `physical_plan/from_proto.rs` had one use of `Column::from_proto` for
the physical-expr `Column`; inlined to `Column::new(...)` at the single
callsite (Phase-2 work will migrate this to the `to_proto` hook).
- `logical_plan/file_formats.rs` has 8 conversion impls between
`*FormatFactory` (foreign in datasource-* crates) and `*OptionsProto`
(foreign in proto-common). A private file-local `FromProto<T>` trait
keeps these organized; it is not exported and has no relationship to
the deleted public traits.
End-state callers see plain `(&p).try_into()?` everywhere, matching the
target architecture in apache#21835's follow-up doc.
Wire format unchanged. 161 proto tests pass (6 pre-existing
parquet-testing submodule failures unrelated).
Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>1 parent e5adb90 commit 8d4ecbf
5 files changed
Lines changed: 11 additions & 77 deletions
File tree
- datafusion/proto/src
- logical_plan
- physical_plan
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
47 | 47 | | |
48 | 48 | | |
49 | 49 | | |
50 | | - | |
51 | | - | |
52 | | - | |
53 | | - | |
54 | | - | |
55 | | - | |
56 | | - | |
57 | | - | |
58 | | - | |
59 | | - | |
60 | | - | |
61 | | - | |
62 | | - | |
63 | | - | |
64 | | - | |
65 | | - | |
66 | | - | |
67 | | - | |
68 | 50 | | |
69 | 51 | | |
70 | 52 | | |
| |||
This file was deleted.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
123 | 123 | | |
124 | 124 | | |
125 | 125 | | |
126 | | - | |
127 | 126 | | |
128 | 127 | | |
129 | 128 | | |
130 | 129 | | |
131 | | - | |
132 | | - | |
133 | 130 | | |
134 | 131 | | |
135 | 132 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
21 | | - | |
22 | 21 | | |
23 | 22 | | |
24 | 23 | | |
| |||
35 | 34 | | |
36 | 35 | | |
37 | 36 | | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
38 | 47 | | |
39 | 48 | | |
40 | 49 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
48 | 48 | | |
49 | 49 | | |
50 | 50 | | |
51 | | - | |
52 | 51 | | |
53 | 52 | | |
54 | 53 | | |
55 | 54 | | |
56 | | - | |
57 | | - | |
58 | | - | |
59 | | - | |
60 | | - | |
61 | | - | |
62 | 55 | | |
63 | 56 | | |
64 | 57 | | |
| |||
256 | 249 | | |
257 | 250 | | |
258 | 251 | | |
259 | | - | |
260 | | - | |
261 | | - | |
262 | | - | |
| 252 | + | |
263 | 253 | | |
264 | 254 | | |
265 | 255 | | |
| |||
0 commit comments