Skip to content

Comments

Fix the WantWriteError test on OS X #31

Merged
exarkun merged 2 commits intomasterfrom
osx-wantwrite
Feb 22, 2014
Merged

Fix the WantWriteError test on OS X #31
exarkun merged 2 commits intomasterfrom
osx-wantwrite

Conversation

@exarkun
Copy link
Member

@exarkun exarkun commented Feb 18, 2014

See #8.

… fill it.

This makes the test pass on OS X.  Previously it failed with the
wrong exception type probably because there was enough room left
in the send buffer for the handshake to start.
@hynek
Copy link
Contributor

hynek commented Feb 20, 2014

FWIW, all tox tests pass for me now on OS X 10.9.

@exarkun
Copy link
Member Author

exarkun commented Feb 22, 2014

Thanks for the feedback hynek!

exarkun added a commit that referenced this pull request Feb 22, 2014
Fix the WantWriteError test on OS X (purely a test bug).
@exarkun exarkun merged commit 08d4ade into master Feb 22, 2014
@exarkun exarkun deleted the osx-wantwrite branch February 22, 2014 14:01
kouk added a commit to kouk/pyopenssl that referenced this pull request Feb 24, 2014
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants