Merged
Conversation
This only applies to the binary curves (ed25519 is cofactor 8 and ed448 is cofactor 4 but we use a different code path for eddsa)
reaperhulk
force-pushed
the
46-ec-check
branch
from
19c19b5 to
d98de5a
Compare
alex
reviewed
Feb 10, 2026
src/rust/src/backend/ec.rs
Outdated
| } | ||
| } | ||
|
|
||
| fn cofactor_check(group: &openssl::ec::EcGroupRef) -> CryptographyResult<bool> { |
Member
There was a problem hiding this comment.
this is a terrible name tbh. I don't see why you wouldn't just inline this into the caller either?
src/rust/src/backend/ec.rs
Outdated
| let mut cofactor = openssl::bn::BigNum::new()?; | ||
| group.cofactor(&mut cofactor, &mut bn_ctx)?; | ||
| let one = openssl::bn::BigNum::from_u32(1)?; | ||
| Ok(cofactor.ucmp(&one) == std::cmp::Ordering::Greater) |
CHANGELOG.rst
Outdated
| ~~~~~~~~~~~~~~~~~~~ | ||
|
|
||
| * Support for ``SECT*`` elliptic curves is deprecated and will be removed in | ||
| the next release. |
alex
approved these changes
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.