Add SSL_set_info_callback function declaration#13375
Merged
reaperhulk merged 1 commit intomainfrom Sep 1, 2025
Merged
Conversation
we need this to have a `set_info_callback` on an SSL.Connection which twisted needs for reasons I don't understand
reaperhulk
approved these changes
Sep 1, 2025
alex
added a commit
to alex/cryptography
that referenced
this pull request
Sep 1, 2025
we need this to have a `set_info_callback` on an SSL.Connection which twisted needs for reasons I don't understand
reaperhulk
pushed a commit
that referenced
this pull request
Sep 1, 2025
* Add SSL_set_info_callback function declaration (#13375) we need this to have a `set_info_callback` on an SSL.Connection which twisted needs for reasons I don't understand * prep for a 45.0.7 releaes * Update CI for the new staticnode location (#13305) * Update CI for the new staticnode location * get CI green
Contributor
|
The callback code is here The I think that this is "legacy" code in Twisted, and the plan is to (re)use newer code to check for server identity. I remember that @glyph has mentioned that he wants to rewrite this code... but I can't find the conversation |
Member
Author
|
It seems like |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
we need this to have a
set_info_callbackon an SSL.Connection which twisted needs for reasons I don't understand