Migrate SPKI parsing from OpenSSL to Rust#10121
Merged
reaperhulk merged 1 commit intopyca:mainfrom Jan 21, 2024
Merged
Conversation
alex
force-pushed
the
spki-parse-rust
branch
15 times, most recently
from
9a42dc6 to
9a78475
Compare
alex
commented
Jan 4, 2024
alex
force-pushed
the
spki-parse-rust
branch
6 times, most recently
from
5c5ea79 to
0a2fa6b
Compare
reaperhulk
reviewed
Jan 19, 2024
reaperhulk
reviewed
Jan 19, 2024
alex
force-pushed
the
spki-parse-rust
branch
3 times, most recently
from
0b153b7 to
62a2983
Compare
botovq
reviewed
Jan 19, 2024
alex
force-pushed
the
spki-parse-rust
branch
2 times, most recently
from
872704c to
f35e89a
Compare
botovq
reviewed
Jan 20, 2024
alex
force-pushed
the
spki-parse-rust
branch
2 times, most recently
from
1b4460d to
0a71e16
Compare
reaperhulk
approved these changes
Jan 21, 2024
|
This seems to be stricter than OpenSSL. In particular, some keys with |
Member
Author
|
@tamird can you file a new ticket with the details of the issue and an example public key? It sounds like this is a full SPKI but using the |
|
It looks like the key was indeed not correct, passing it through Just flagging that this is a behavior change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO:
DH_set_flags(dh, DH_FLAG_TYPE_DHX))