Repository navigation
Commit 33181a7
Reject critical nameConstraints extensions containing directoryName constraints (#15014)
* Handle directoryName name constraints without erroring
Previously, evaluating a directoryName name constraint against a
directoryName SAN always failed with a generic "unsupported name
constraint" error. We still don't implement directoryName matching;
instead, such a constraint now simply never matches: an excluded
directoryName subtree never excludes anything, and a permitted
directoryName subtree fails with a dedicated error message since no
directoryName SAN can ever satisfy it.
https://claude.ai/code/session_01LJgFCNp7irHqqfQ6jXmPhE
* Apply directoryName name constraints to the subject field
Per RFC 5280 4.2.1.10, directoryName name constraints apply to the
subject field (when non-empty) in addition to directoryName SANs.
Since we don't implement directoryName matching, a directoryName
constraint that applies to a subsequent certificate with a non-empty
subject is now rejected as unsupported, rather than silently ignored.
A directoryName constraint paired with a directoryName SAN continues
to be rejected as an unsupported name constraint.
https://claude.ai/code/session_01LJgFCNp7irHqqfQ6jXmPhE
* Reject critical nameConstraints containing directoryName constraints
Instead of tracking subject DNs through the name chain, simply reject
any chain where a critical nameConstraints extension contains a
directoryName constraint. RFC 5280 4.2.1.10 requires directoryName
constraints to be applied to the subject field (in addition to
directoryName SANs), and requires applications that cannot process a
constraint in a critical nameConstraints extension to reject the
certificate. We don't implement directoryName matching, so the only
conforming option for a critical extension is rejection.
Non-critical extensions may be partially ignored, so their
directoryName constraints fall through to the existing per-SAN
evaluation, which continues to reject directoryName-vs-directoryName
pairs as unsupported.
https://claude.ai/code/session_01LJgFCNp7irHqqfQ6jXmPhE
* Address review feedback
- Drop the changelog entry
- Reframe the comment around RFC 5280's subject-field requirement,
which is what the per-SAN evaluation can't cover
- Restructure the directoryName scan as two ||'d helper calls
https://claude.ai/code/session_01LJgFCNp7irHqqfQ6jXmPhE
---------
Co-authored-by: Claude <[email protected]>1 parent 6080dc7 commit 33181a7
2 files changed
Lines changed: 182 additions & 2 deletions
File tree
- src/rust/cryptography-x509-verification/src
- tests/x509/verification
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
22 | | - | |
| 22 | + | |
23 | 23 | | |
24 | 24 | | |
25 | 25 | | |
| |||
424 | 424 | | |
425 | 425 | | |
426 | 426 | | |
427 | | - | |
| 427 | + | |
| 428 | + | |
| 429 | + | |
| 430 | + | |
| 431 | + | |
| 432 | + | |
| 433 | + | |
| 434 | + | |
| 435 | + | |
| 436 | + | |
| 437 | + | |
| 438 | + | |
| 439 | + | |
| 440 | + | |
| 441 | + | |
| 442 | + | |
| 443 | + | |
| 444 | + | |
| 445 | + | |
| 446 | + | |
| 447 | + | |
| 448 | + | |
| 449 | + | |
| 450 | + | |
| 451 | + | |
| 452 | + | |
| 453 | + | |
| 454 | + | |
| 455 | + | |
| 456 | + | |
| 457 | + | |
| 458 | + | |
428 | 459 | | |
429 | 460 | | |
430 | 461 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
860 | 860 | | |
861 | 861 | | |
862 | 862 | | |
| 863 | + | |
| 864 | + | |
| 865 | + | |
| 866 | + | |
| 867 | + | |
| 868 | + | |
| 869 | + | |
| 870 | + | |
| 871 | + | |
| 872 | + | |
| 873 | + | |
| 874 | + | |
| 875 | + | |
| 876 | + | |
| 877 | + | |
| 878 | + | |
| 879 | + | |
| 880 | + | |
| 881 | + | |
| 882 | + | |
| 883 | + | |
| 884 | + | |
| 885 | + | |
| 886 | + | |
| 887 | + | |
| 888 | + | |
| 889 | + | |
| 890 | + | |
| 891 | + | |
| 892 | + | |
| 893 | + | |
| 894 | + | |
| 895 | + | |
| 896 | + | |
| 897 | + | |
| 898 | + | |
| 899 | + | |
| 900 | + | |
| 901 | + | |
| 902 | + | |
| 903 | + | |
| 904 | + | |
| 905 | + | |
| 906 | + | |
| 907 | + | |
| 908 | + | |
| 909 | + | |
| 910 | + | |
| 911 | + | |
| 912 | + | |
| 913 | + | |
| 914 | + | |
| 915 | + | |
| 916 | + | |
| 917 | + | |
| 918 | + | |
| 919 | + | |
| 920 | + | |
| 921 | + | |
| 922 | + | |
| 923 | + | |
| 924 | + | |
| 925 | + | |
| 926 | + | |
| 927 | + | |
| 928 | + | |
| 929 | + | |
| 930 | + | |
| 931 | + | |
| 932 | + | |
| 933 | + | |
| 934 | + | |
| 935 | + | |
| 936 | + | |
| 937 | + | |
| 938 | + | |
| 939 | + | |
| 940 | + | |
| 941 | + | |
| 942 | + | |
| 943 | + | |
| 944 | + | |
| 945 | + | |
| 946 | + | |
| 947 | + | |
| 948 | + | |
| 949 | + | |
| 950 | + | |
| 951 | + | |
| 952 | + | |
| 953 | + | |
| 954 | + | |
| 955 | + | |
| 956 | + | |
| 957 | + | |
| 958 | + | |
| 959 | + | |
| 960 | + | |
| 961 | + | |
| 962 | + | |
| 963 | + | |
| 964 | + | |
| 965 | + | |
| 966 | + | |
| 967 | + | |
| 968 | + | |
| 969 | + | |
| 970 | + | |
| 971 | + | |
| 972 | + | |
| 973 | + | |
| 974 | + | |
| 975 | + | |
| 976 | + | |
| 977 | + | |
| 978 | + | |
| 979 | + | |
| 980 | + | |
| 981 | + | |
| 982 | + | |
| 983 | + | |
| 984 | + | |
| 985 | + | |
| 986 | + | |
| 987 | + | |
| 988 | + | |
| 989 | + | |
| 990 | + | |
| 991 | + | |
| 992 | + | |
| 993 | + | |
| 994 | + | |
| 995 | + | |
| 996 | + | |
| 997 | + | |
| 998 | + | |
| 999 | + | |
| 1000 | + | |
| 1001 | + | |
| 1002 | + | |
| 1003 | + | |
| 1004 | + | |
| 1005 | + | |
| 1006 | + | |
| 1007 | + | |
| 1008 | + | |
| 1009 | + | |
| 1010 | + | |
| 1011 | + | |
0 commit comments