Fix compilation with Intel's compiler #937
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ICC was reporting that `try_direct_conversions()` cannot be `constexpr` because `handle` is not a literal type. The fix removes `constexpr` from the function since it isn't strictly needed. This commit also suppresses new false positive warnings which mostly appear in constexpr contexts (where the compiler knows conversions are safe).
Member
|
LGTM. We've pretty much always taken the path of disabling false positive warnings rather than changing code to work around them, so it seems pretty reasonable to keep doing so for ICC. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ICC failed to compile and was reporting that
try_direct_conversions()cannot beconstexprbecausehandleis not a literal type (it is, ICC just doesn't know it). The fix removesconstexprfrom the function since it isn't strictly needed.This commit also suppresses new false positive warnings which mostly appear in
constexprcontexts (where the compiler knows conversions are safe). Suppressing all of these may seem heavy-handed, but these really are false positives -- other compilers have the same warnings enabled without any of the issues for compile-time constants.