Skip to content

fix(cmake): LTO warning of gcc >= 11.4 #5791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
henryiii merged 1 commit into from
Aug 12, 2025
Merged

fix(cmake): LTO warning of gcc >= 11.4 #5791

henryiii merged 1 commit into from
Aug 12, 2025

Conversation

@rhaschke
Copy link
Contributor

@rhaschke rhaschke commented Aug 10, 2025 •
edited by henryiii
Loading

Description

gcc >= 11.4 issues the following warning with -flto:
lto-wrapper: warning: using serial compilation of n LTRANS jobs

According to this stackoverflow issue, we need to use -flto=auto.

Suggested changelog entry:

  • Fix gcc 11.4+ warning about serial compilation.

@rhaschke rhaschke requested a review from henryiii as a code owner August 10, 2025 17:42
rwgk
rwgk approved these changes Aug 12, 2025
View reviewed changes
Copy link
Collaborator

@rwgk rwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@henryiii WDYT?

@henryiii henryiii merged commit 580494c into pybind:master Aug 12, 2025
86 checks passed
@github-actions github-actions bot added the needs changelog Possibly needs a changelog entry label Aug 12, 2025
@rhaschke rhaschke deleted the flto=auto branch August 13, 2025 08:02
@henryiii henryiii changed the title Fix LTO warning of gcc >= 11.4 fix(cmake): LTO warning of gcc >= 11.4 Aug 21, 2025
@henryiii henryiii removed the needs changelog Possibly needs a changelog entry label Aug 22, 2025
@BrewTestBot BrewTestBot mentioned this pull request Aug 22, 2025
Merged
@chillenb
Copy link

chillenb commented Aug 23, 2025

Why not use https://cmake.org/cmake/help/latest/prop_tgt/INTERPROCEDURAL_OPTIMIZATION.html ?

@henryiii
Copy link
Collaborator

henryiii commented Aug 23, 2025 •
edited
Loading

If you set that (via CMAKE_INTERPROCEDURAL_OPTIMIZATION), it is used. We support thin vs. regular LTO, so that's why both methods are still supported (ours and CMake's).

@chillenb
Copy link

chillenb commented Aug 23, 2025

Thanks for the clarification!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rwgk rwgk rwgk approved these changes

@henryiii henryiii Awaiting requested review from henryiii henryiii is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rhaschke @chillenb @henryiii @rwgk