Avoid CMP0048 warning #570
Conversation
|
Setting a policy to In this case, it should be possible to set the policy to |
Fixes pybind#567. If pybind's CMakeLists gets loaded via an include_directory from another CMakeLists with a higher minimum version (e.g. 3.0), the project() command without a version produces a CMP0048 warning. This commit explicitly requests the new behaviour if the policy exists, as it won't cause problems (we set VERSION later).
jagerman
force-pushed
the
fix-CMP0048-warning
branch
from
0d1f15a to
5772a35
Compare
|
Changed it to NEW. |
|
There is a strange failure on Travis-OSX for Python 3.5 (likely unrelated to this PR). Is it possible that |
|
Homebrew just got Python 3.6 ( |
|
ok, sounds good to me. @jagerman -- do you want to include a line in .travis.yml to allow the test failure? Thanks and happy Christmas |
pybind#570 (comment) "Homebrew just got Python 3.6 (brew install python3), but numpy and scipy don't have binary wheels for 3.6 yet so it's trying to compile from source and failing."
* Temporarily allows osx homebrew Python 3.6 to fail. #570 (comment) "Homebrew just got Python 3.6 (brew install python3), but numpy and scipy don't have binary wheels for 3.6 yet so it's trying to compile from source and failing."
|
Merged, thanks! |
3 participants
Fixes #567.
If pybind's CMakeLists gets loaded via an include_directory from another CMakeLists with a higher minimum version (e.g. 3.0), the project() command without a version produces a CMP0048 warning.
This commit explicitly requests the old behaviour (if the policy exists in the active cmake).