Replace ubuntu-latest with ubuntu-22.04
#4382
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…CXX_FLAGS="-D_=1" with 3.9
…-DCMAKE_CXX_FLAGS="-D_=1" with 3.9" This reverts commit 3ec984e.
…t in upstream.yml
rwgk
changed the title
ubuntu-latest with ubuntu-22.04
Collaborator
Author
|
Commit cdfd995 confirms that we get back to all-green by systematically changing all I'll try to make the changes more selective, to only address breakages. |
…4, except in upstream.yml" This reverts commit cdfd995.
Skylion007
approved these changes
Dec 4, 2022
Collaborator
Author
|
Thanks @Skylion007! I wrote up the rationale in the PR description. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Using previous configure.yml logs to pin-point when
ubuntu-latestchanged from 20.04 to 22.04:2022-12-02T01:51:20.8819798ZImage: ubuntu-20.04 — last success2022-12-02T13:46:45.3899378ZImage: ubuntu-22.04 — first failureThere are multiple problems:
variantor boost/mpl).General: it does not make much sense to test Python 3.6, cmake 3.4, valgrind with Python 3.9 (all very or somewhat outdated) on the "tatest" platform.
Opinion: it will be best to pin those indefinitely, modernize valgrind testing with the latest platform & Python (when someone gets to it), and drop cmake 3.4 and Python 3.6 entirely.
Conservative resolution: change
ubuntu-latesttoubuntu-20.04, but only as required to resolve breakages.Suggested changelog entry: