Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: pybind/pybind11
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: rhaschke/pybind11
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: rvalue-argument-fix2
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 5 commits
  • 1 file changed
  • 1 contributor

Commits on Oct 20, 2020

  1. new move_only_holder_caster

    @rhaschke
    rhaschke committed Oct 20, 2020
    Configuration menu
    Copy the full SHA
    bcc3776 View commit details
    Browse the repository at this point in the history

  2. argument_loader doesn't consider actual argument types

    @rhaschke
    rhaschke committed Oct 20, 2020
    Configuration menu
    Copy the full SHA
    6a85f82 View commit details
    Browse the repository at this point in the history

  3. remove unused cast operators

    @rhaschke
    rhaschke committed Oct 20, 2020
    Configuration menu
    Copy the full SHA
    7254b3b View commit details
    Browse the repository at this point in the history

  4. solved multiple access issue

    @rhaschke
    rhaschke committed Oct 20, 2020
    Configuration menu
    Copy the full SHA
    8b45197 View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2020

  1. fixup! solved multiple access issue 

    - Unregister instance after moving, thus avoiding reusing an invalidated instance pointer later on.
  Note: this implementation is rather hacky, because in hopes that the function clear_instance()
        inlined in detail/class.h will be available in cast.h as well.
        A clean solution should move the corresponding code into a shared header.
        Not sure also, I should clear_instance() or only deregister_instance()?

- (Partially) reverts 8b45197
  Moving the same variable twice into a function will error in C++ as well.
  We don't need to catch that in Python, do we?
    @rhaschke
    rhaschke committed Dec 10, 2020
    Configuration menu
    Copy the full SHA
    6b3c9b5 View commit details
    Browse the repository at this point in the history
Loading