FEAT: Community package listing pages for astropy + SunPy by lwasser · Pull Request #207 · pyOpenSci/pyopensci.github.io

lwasser · 2023-06-22T14:48:45Z

Landing page with community partner buttons

First - the landing page with new community specific buttons at the top leading to a community partner page

Search feature to find astropy affiliated packages on our main python-packages landing page.

Then we have the landing page where someone might search for astropy to find related packages.

Community landing page

I envision something like this (styles can be fixed) that listed only the affiliated packages. A few notes

i created a placeholder graphic at the top for astropy - we can change it it's just a mockup.
We should discuss in more detail what metrics we want to track here. I was thinking it would be nice to be able to sort packages by varying metrics.
Based upon what we decide above, we then could create a xml feed that shared data associated with a select group of packages to populate another website. we'd need to agree on what items would be most useful to share in that feed.

To see the specific tasks where the Asana app for GitHub is being used, see below:
- https://app.asana.com/0/0/1206583355703723

lwasser · 2023-07-05T18:17:10Z

@@ -1,3 +1,90 @@
+- package_name: astro-package3


these are just dummy placeholder packages to test the search for astropy functionality - do not worry about the information in each of these but if we need new FIELDS that is something to consider

pllim · 2023-07-28T19:08:56Z

@lwasser , I vaguely remember you said you added a link back to "original review" to the listing of an accepted package in a mock-up. Was it this mockup? I don't see a preview link and I am not sure if the screenshots are up-to-date. Hope you can clarify. Thanks!

lwasser · 2023-07-28T22:36:42Z

hey @pllim i've actually been working on this!! it's not in this mockup branch YET (i need to rebase) BUT you can see it live on the website - i just pushed it. it took me a bit of time as i had to update the code that parses our reviews. but it's done now!! check it our here . now that it's working you can imaging the exact same thing on this mockup branch once i rebase!

There is a tiny bug i need to fix on the packaging page in terms of sorting but that will be fixed in the next 30 minutes :)

let me know if you have any other questions or if you need anything else. I have it on my list to review the APE in the upcoming days (most likely on monday).

pllim

I don't have a lot of comments when it comes to website designs. I should ping those listed under "Astropy.org web page maintainer" on https://www.astropy.org/team : @hamogu @dhomeier @eteq

At a glance though, you might need Astropy logo and banner that are also compatible with dark mode. We have some here that we use for astropy documentation: https://github.com/astropy/astropy/tree/main/docs/_static

Thanks!

willingc · 2024-11-14T20:14:36Z

@lwasser Do we still want this open or should it be closed?

pllim · 2024-11-14T20:17:11Z

Closed? I thought Astropy had agreement with pyOpenSci on cross-listing? Will this be replaced with something else?

lwasser · 2024-11-15T00:49:13Z

oh this definitely needs to be reviewed and merged!! We don't want to close it. this just fell by the wayside with the fall festival and other items going on. I am actually onboarding someone now to help with these types of tasks so they don't go stale because of me!! i'll make sure this one is a priority, but it may be another month until we get up and running with this!

lwasser · 2024-11-15T00:50:18Z

@pllim maybe we just merge it as is (with someone fixing whatever is buggy in the pr) and allow for the astropy community to chime in as they see issues in the future? we have a handful of astropy packages now, so the page should look better than when we started with no packages!!

pllim · 2024-11-15T01:23:47Z

Fine by me but let's hear from @dhomeier and @hamogu as well since they are the current Astropy Affiliated Editors. Thanks!

hamogu

I'm not a javascript programmer, so I can't say much about the implementation, but I still think that we want a page like that - and with the number of accepted packages going up, now is a good time to do so. I suggest to merge this relatively quickly and if we want to iterate on the design (I don't have any strong opinions on that, though) then we can always do that in follow-up PRs.

lwasser · 2024-11-15T16:10:37Z

@hamogu, this sounds good to me.
i'll do this: I'll revisit the PR today, fix the small conflict above, and make it merge-ready. We can always make additional edits to it in the future via opening issues and iterating on it. This pr has been open for over a year so it would be nice to merge it!!

willingc · 2024-11-15T23:34:06Z

+
+To view packages affiliated with our partner communities that are a part of our peer review partnership program, click on a community link below. [Learn more about our community partnerships here.](#)
+
+<a href="/partners/astropy.html"><button class="button community">Astropy</button></a>


Should this link be href="/communities/astropy.html"

oh i like using the word community in the url over partners. yes let's update it. we will want to update the yaml as well for the page. I will do that locally!!

willingc · 2024-11-15T23:34:56Z

+                <li><a href="{{ apackage.archive }}" rel="permalink"><i class="fas fa-bookmark fa-fw"></i> JOSS Approved</a></li>
+            {% endif %}
+            {% if apackage.astropy %}
+                <li><a href="partners/astropy.html"><i class="fa-solid fa-check-double"></i> <img src="http://img.shields.io/badge/Affiliated-Astropy-orange.svg?style=flat" alt="Astropy" /></a></li>


Are we using partners or communities in this link?

willingc · 2024-11-15T23:35:09Z

+                <li><a href="partners/astropy.html"><i class="fa-solid fa-check-double"></i> <img src="http://img.shields.io/badge/Affiliated-Astropy-orange.svg?style=flat" alt="Astropy" /></a></li>
+            {% endif %}
+            {% if apackage.sunpy %}
+                <li><a href="partners/astropy.html"><i class="fa-solid fa-check-double"></i> <img src="http://img.shields.io/badge/Affiliated-Sunpy-yellow.svg?style=flat" alt="Astropy" /></a></li>


Same question here.

willingc · 2024-11-15T23:36:31Z

+  overlay_filter: 0.6
+  overlay_image: images/partners/astropy-banner.png
+  image_alt: "Digital elevation model"
+permalink: partners/astropy.html


communities or partners

lwasser · 2024-11-16T00:32:14Z

Ok friends. I am going to merge this with the updates.
we may want to adjust text and such. AND I think I found a bug where some package categories are not displayed /filtered properly in the isotope. I will turn this comment into an issue that we can track separately.

The new page shows 3 Astropy packages have been accepted! 🚀

lwasser · 2024-11-16T00:33:16Z

the ci failures

new partner page (fixed when this is merged)
a DOI link issue. that could just be a zenodo issue.

pllim · 2024-11-18T18:47:40Z

Thanks! https://www.pyopensci.org/communities/astropy.html

pllim · 2024-11-18T18:57:52Z

FWIW I opened a couple of follow-up issues. Thanks again, all!

lwasser · 2024-11-19T16:25:13Z

wonderful. thanks @pllim

lwasser commented Jul 5, 2023

View reviewed changes

lwasser force-pushed the astropy branch from e40bd50 to ed11ff9 Compare February 2, 2024 23:16

lwasser changed the title ~~FEAT: Start at community mockup / astropy~~ FEAT: Start at community mockup / astropy + SunPy Feb 6, 2024

lwasser changed the title ~~FEAT: Start at community mockup / astropy + SunPy~~ FEAT: Community package listing pages for astropy + SunPy Feb 6, 2024

lwasser mentioned this pull request Feb 12, 2024

APE 22 follow-up: Update Affiliated guidelines and process astropy/astropy-project#372

Closed

pllim reviewed Feb 13, 2024

View reviewed changes

lwasser mentioned this pull request Feb 20, 2024

Astropy Partnership: TODO list pyOpenSci/software-peer-review#276

Closed

5 of 8 tasks

pllim mentioned this pull request May 13, 2024

Update affiliated package listing script to get from pyopensci astropy/astropy.github.com#579

Closed

willingc added the DO-NOT-MERGE A caution that a PR is not ready to be merged label Nov 4, 2024

hamogu reviewed Nov 15, 2024

View reviewed changes

Comment thread _pages/python-packages.md Resolved

willingc reviewed Nov 15, 2024

View reviewed changes

lwasser added 3 commits November 15, 2024 17:13

Start at community mockups

eecd217

Fix: final draft of landing page

5f812f5

Add: Astropy landing page

1da5ae9

lwasser force-pushed the astropy branch from c4180b8 to 1da5ae9 Compare November 16, 2024 00:14

feat: fix astropy landing page

b51207b

lwasser merged commit d9d34a6 into pyOpenSci:main Nov 16, 2024

lwasser deleted the astropy branch November 16, 2024 00:33

This was referenced Nov 18, 2024

FEATURE: Hide or customize search categories on Astropy page #518

Closed

BUG: Broken link on Astropy page #519

Closed

pllim mentioned this pull request Nov 19, 2024

Update link to pyOpenSci partners page for Astropy astropy/astropy.github.com#641

Merged

erik-whiting mentioned this pull request Jan 6, 2025

Fix some link issues #544

Merged


		To view packages affiliated with our partner communities that are a part of our peer review partnership program, click on a community link below. [Learn more about our community partnerships here.](#)

		<a href="/partners/astropy.html"><button class="button community">Astropy</button></a>

Conversation

lwasser commented Jun 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Landing page with community partner buttons

Search feature to find astropy affiliated packages on our main python-packages landing page.

Community landing page

Uh oh!

lwasser Jul 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pllim commented Jul 28, 2023

Uh oh!

lwasser commented Jul 28, 2023

Uh oh!

pllim left a comment

Choose a reason for hiding this comment

Uh oh!

willingc commented Nov 14, 2024

Uh oh!

pllim commented Nov 14, 2024

Uh oh!

lwasser commented Nov 15, 2024

Uh oh!

lwasser commented Nov 15, 2024

Uh oh!

pllim commented Nov 15, 2024

Uh oh!

hamogu left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

lwasser commented Nov 15, 2024

Uh oh!

willingc Nov 15, 2024

Choose a reason for hiding this comment

Uh oh!

lwasser Nov 15, 2024

Choose a reason for hiding this comment

Uh oh!

willingc Nov 15, 2024

Choose a reason for hiding this comment

Uh oh!

willingc Nov 15, 2024

Choose a reason for hiding this comment

Uh oh!

willingc Nov 15, 2024

Choose a reason for hiding this comment

Uh oh!

lwasser commented Nov 16, 2024

Uh oh!

lwasser commented Nov 16, 2024

Uh oh!

pllim commented Nov 18, 2024

Uh oh!

pllim commented Nov 18, 2024

Uh oh!

lwasser commented Nov 19, 2024

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

lwasser commented Jun 22, 2023 •

edited

Loading

lwasser Jul 5, 2023 •

edited

Loading