Adds a note for the fact that __str__ could return non-ascii unicodes in Python 2 #308
+6
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
changed the title
Codecov Report
@@ Coverage Diff @@
## master #308 +/- ##
============================================
+ Coverage 82.02% 82.03% +0.01%
Complexity 688 688
============================================
Files 82 82
Lines 8367 8367
Branches 372 372
============================================
+ Hits 6863 6864 +1
+ Misses 1365 1364 -1
Partials 139 139
Continue to review full report at Codecov.
|
Collaborator
|
Thanks! Merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes to add a simple note and comment for #306. It might be trivial but good to know.