Repository navigation
ROB: Add outline items when the outlines are not an indirect dictionary - #4305
Merged
stefan6419846 merged 2 commits intoNov 2, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4305 +/- ##
=======================================
Coverage 98.66% 98.67%
=======================================
Files 59 59
Lines 12102 12110 +8
Branches 2298 2302 +4
=======================================
+ Hits 11941 11949 +8
Misses 84 84
Partials 77 77 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
stefan6419846
approved these changes
Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PdfWriter.add_outline_item()on a document whose/Outlinesentry is a number, array, string or null raised aTypeError('NumberObject' object is not iterable), and one whose/Outlinesis a direct dictionary raisedAttributeError: 'DictionaryObject' object has no attribute 'indirect_reference', becauseget_outline_root()wrapped the entry in aTreeObjectand replaced it by its object number.A direct dictionary is now stored as a new indirect outline root, and an entry that is not a dictionary is replaced by a new outline root, with a warning unless it is null