Repository navigation
ROB: Skip an embedded file specification that is not a dictionary - #4256
Merged
stefan6419846 merged 1 commit intoOct 27, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4256 +/- ##
=======================================
Coverage 98.37% 98.37%
=======================================
Files 59 59
Lines 11913 11918 +5
Branches 2247 2249 +2
=======================================
+ Hits 11719 11724 +5
Misses 106 106
Partials 88 88 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
stefan6419846
approved these changes
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reader.attachmentscrashed withTypeError: argument of type 'NumberObject' is not iterablewhen an entry of the embedded files name tree points to something that is not a dictionary, for example[(a.txt) 5]. #4037 made the levels above it (the/Namestree,/EmbeddedFiles,/Kidsand the name lists) warn and skip, but the file specification itself was used without a check._load_from_names()now does the same for the file specification: a non-dictionary is reported with_report_malformed()(a warning, orPdfReadErrorin strict mode, sostrictis now passed down), and a null value is skipped silently like the other null entries. Added the cases toMALFORMED_NAME_TREE_CATALOGS(directly in/Namesand in a kid) and toSPEC_CONFORMANT_EMPTY_CATALOGS.