Repository navigation
ROB: Do not crash on an outline action without a type - #4098
Merged
stefan6419846 merged 2 commits intoSep 23, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4098 +/- ##
=======================================
Coverage 98.09% 98.10%
=======================================
Files 59 59
Lines 11521 11565 +44
Branches 2151 2164 +13
=======================================
+ Hits 11302 11346 +44
+ Misses 125 124 -1
- Partials 94 95 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
stefan6419846
requested changes
Sep 17, 2026
stefan6419846
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_build_outline_item subscripts the action type directly:
/S is required by the spec, but a file that omits it takes down reader.outline
with a bare KeyError: '/S' rather than a message naming the problem.
The lookup now follows the handling already used for /Title and /D in the same
function: strict mode raises PdfReadError naming the missing attribute, and
lenient mode falls through to the destination-less path, so the item keeps its
title instead of the whole outline failing.
Offline suite passes, 1366 tests.
Used Claude (Opus) to help locate and patch this; I reviewed and tested the change.