Repository navigation
ROB: Do not crash when the annotations are not an array - #4046
Merged
stefan6419846 merged 1 commit intoSep 4, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4046 +/- ##
=======================================
Coverage 98.05% 98.05%
=======================================
Files 57 57
Lines 11273 11277 +4
Branches 2131 2132 +1
=======================================
+ Hits 11054 11058 +4
Misses 122 122
Partials 97 97 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
stefan6419846
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
page.annotations casts the /Annots entry to an array and hands it straight back, so
a page whose /Annots is a number, a string or a dictionary crashes with
"'NumberObject' object is not iterable" as soon as anything iterates it.
The property is already typed Optional[ArrayObject] and returns None when /Annots is
absent, so an entry that cannot be one is logged and returns None as well. The writer
paths that use it already check for None.
I could not run the tests that download the corpus locally; the offline suite passes,
1262 tests.
Used Claude (Opus) to help locate and patch this; I reviewed and tested the change.