Repository navigation
ROB: Reject a page box that is not an array - #4041
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4041 +/- ##
=======================================
Coverage 98.04% 98.04%
=======================================
Files 57 57
Lines 11225 11227 +2
Branches 2114 2115 +1
=======================================
+ Hits 11006 11008 +2
Misses 122 122
Partials 97 97 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
stefan6419846
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_get_rectangle checks the length only when the value is already an ArrayObject.
Anything else falls through to RectangleObject(retval) behind a type: ignore, where
it fails with "object of type 'NumberObject' has no len()" - which says nothing about
which box was wrong.
It now raises a ValueError naming the box, in the same wording as the existing
too-few-values error a few lines below, and the type: ignore is no longer needed.
This is not a behavioural change in the sense of newly rejecting a valid file: the
old code already failed on the same input, just with a less useful error.
I could not run the tests that download the corpus locally; the offline suite passes,
1237 tests.
Used Claude (Opus) to help locate and patch this; I reviewed and tested the change.