Repository navigation
ROB: Do not crash when the destination tree is not a dictionary - #4020
Merged
stefan6419846 merged 1 commit intoAug 28, 2026
Merged
stefan6419846 merged 1 commit into
stefan6419846 merged 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4020 +/- ##
=======================================
Coverage 98.01% 98.01%
=======================================
Files 57 57
Lines 11157 11163 +6
Branches 2096 2098 +2
=======================================
+ Hits 10935 10941 +6
Misses 124 124
Partials 98 98 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
stefan6419846
requested changes
Aug 26, 2026
RavSinghChandan
force-pushed
the
named-destinations-not-a-dictionary
branch
from
August 27, 2026 02:32
031caaa to
faaf108
Compare
Contributor
Author
|
Added the IDs. |
stefan6419846
requested changes
Aug 27, 2026
stefan6419846
left a comment
stefan6419846
left a comment
Collaborator
There was a problem hiding this comment.
I am sorry, GitHub seems to somehow have messed up when I tried to merge the latest changes from main into your branch.
Could you please check if you are able to resolve this in a clean fashion? Thanks.
RavSinghChandan
force-pushed
the
named-destinations-not-a-dictionary
branch
2 times, most recently
from
August 27, 2026 14:41
dd04d68 to
a1b8eff
Compare
_get_named_destinations casts /Dests and /Names to a DictionaryObject and then tests membership on the result, so a file where either holds a number, a string or an array raised 'TypeError: argument of type NumberObject is not iterable' from reader.named_destinations. The references are resolved first, since both are usually indirect, and a tree that cannot be walked is reported the way the cycle in the same function already is.
RavSinghChandan
force-pushed
the
named-destinations-not-a-dictionary
branch
from
August 28, 2026 03:41
a1b8eff to
5fd3a10
Compare
stefan6419846
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_get_named_destinationscasts/Destsand/Namesto aDictionaryObjectand then tests membership on the result, so a file where either holds a number, a string or an array brings down the read:The references are resolved first, since both are usually indirect, and a tree that cannot be walked is reported the way the cycle in the same function already is.
Reverting the change fails the four new tests