Repository navigation
BUG: Reject a page range with a zero stride - #4004
Merged
stefan6419846 merged 2 commits intoAug 25, 2026
Merged
Conversation
PageRange("::0") was accepted and PageRange.valid("::0") returned True, but
the range cannot be applied: slice() takes a zero step and then raises
ValueError from indices(), away from the string that caused it. Through
PdfWriter.append the same input surfaces as a TypeError about the pages
argument instead.
Every other malformed range is refused at construction with ParseError, so a
zero stride now is too, and valid() defers to the constructor rather than
matching the pattern a second time.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4004 +/- ##
=======================================
Coverage 97.98% 97.98%
=======================================
Files 57 57
Lines 11106 11118 +12
Branches 2080 2083 +3
=======================================
+ Hits 10882 10894 +12
Misses 125 125
Partials 99 99 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
The rewritten valid() rejects anything that is not a slice, a PageRange or a string, which nothing exercised.
stefan6419846
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PageRange("::0")is accepted andPageRange.valid("::0")returnsTrue, but the range cannot be applied:slice()takes a zero step happily and only raises fromindices(), away from the string that caused it. ThroughPdfWriter.append(pages="::0")the same input surfaces as aTypeErrorabout the pages argument instead, which points the reader somewhere else entirely.Every other malformed range is refused at construction with
ParseError, so a zero stride now is too.valid()defers to the constructor rather than matching the pattern a second time, so the two cannot disagree again.Reverting the change fails the three new tests