Repository navigation
DOC: Note why the entity declaration flag is typed as a bool - #4000
Merged
stefan6419846 merged 1 commit intoAug 24, 2026
Merged
Conversation
expat passes an int for is_parameter_entity, as documented in expat.h and unchanged since 2003, but typeshed declares the handler with a bool. Running the tests under typeguard reports the mismatch, so the reason for keeping the annotation as it stands is worth recording. Follow-up to py-pdf#3994.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4000 +/- ##
=======================================
Coverage 97.98% 97.98%
=======================================
Files 57 57
Lines 11104 11104
Branches 2080 2080
=======================================
Hits 10880 10880
Misses 125 125
Partials 99 99 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
stefan6419846
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #3994, which you offered to merge.
expat passes an int for
is_parameter_entity, as documented inexpat.hand unchanged since 2003, but typeshed declares the handler with a bool. Running the tests under typeguard reports the mismatch, so a one-line comment recording why the annotation stays as it is should save the next person the same detour.No behaviour change