MAINT: Remove unreachable code in read_block_backwards#1250
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1250 +/- ##
==========================================
+ Coverage 94.67% 94.71% +0.03%
==========================================
Files 30 30
Lines 4976 4974 -2
Branches 1025 1024 -1
==========================================
Hits 4711 4711
+ Misses 149 148 -1
+ Partials 116 115 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
MasterOdin
reviewed
Aug 18, 2022
| @@ -177,8 +177,6 @@ def read_block_backwards(stream: StreamType, to_read: int) -> bytes: | |||
| read = stream.read(to_read) | |||
| # Seek to the start of the block we read after reading it. | |||
| stream.seek(-to_read, SEEK_CUR) | |||
Member
There was a problem hiding this comment.
Should the comment about "The stream's position should be unchanged" be removed since this is changing the final position of the stream before returning?
Member
Author
There was a problem hiding this comment.
Yes! Thank you for the hint 🤗
MasterOdin
reviewed
Aug 19, 2022
Co-authored-by: Matthew Peveler <[email protected]>
MartinThoma
added a commit
that referenced
this pull request
Aug 21, 2022
Robustness (ROB): - Decrypt returns empty bytestring (#1258) Documentation (DOC): - Adding WevertonGomes as a Contributor Developer Experience (DEV): - Modify CI to better verify built package contents (#1244) Maintenance (MAINT): - Remove unused sign function in _extract_text (#1262) - Remove \'mine\' as PdfMerger always creates the stream (#1261) - Let PdfMerger._create_stream raise NotImplemented (#1251) - password param of _security._alg32(...) is only a string, not bytes (#1259) - Remove unreachable code in read_block_backwards (#1250) Testing (TST): - Delete annotations (#1263) - Close PdfMerger in tests (#1260) - PdfReader.xmp_metadata workflow (#1257) - Various PdfWriter (Layout, Bookmark deprecation) (#1249) Full Changelog: 2.10.2...2.10.3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think that part is dead code, because it's prevented by
stream.tell() < to_read