MAINT: Split generic.py#1229
Merged
Merged
Conversation
MartinThoma
force-pushed
the
generic-split
branch
5 times, most recently
from
August 13, 2022 17:22
56c59d9 to
e27b272
Compare
MartinThoma
force-pushed
the
generic-split
branch
from
August 13, 2022 17:32
e27b272 to
8ac85ba
Compare
Codecov Report
@@ Coverage Diff @@
## main #1229 +/- ##
==========================================
+ Coverage 92.58% 92.65% +0.06%
==========================================
Files 24 30 +6
Lines 4939 4981 +42
Branches 1025 1026 +1
==========================================
+ Hits 4573 4615 +42
Misses 229 229
Partials 137 137
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Member
Author
|
|
MartinThoma
force-pushed
the
generic-split
branch
from
August 13, 2022 18:59
de947c5 to
b7dfc2e
Compare
MartinThoma
added a commit
that referenced
this pull request
Aug 15, 2022
Bug Fixes (BUG): - TreeObject.remove_child had a non-PdfObject assignment for Count (#1233, #1234) - Fix stream truncated prematurely (#1223) Documentation (DOC): - Fix docstring formatting (#1228) Maintenance (MAINT): - Split generic.py (#1229) Testing (TST): - Decrypt AlgV4 with owner password (#1239) - AlgV5.generate_values (#1238) - TreeObject.remove_child / empty_tree (#1235, #1236) - create_string_object (#1232) - Free-Text annotations (#1231) - generic._base (#1230) - Strict get fonts (#1226) - Increase PdfReader coverage (#1219, #1225) - Increase PdfWriter coverage (#1237) - 100% coverage for utils.py (#1217) - Writer exception non-binary stream (#1218) - Don't check coverage for deprecated code (#1216) Full Changelog: 2.10.0...2.10.1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The aim of this refactoring PR is to explicitly define the interface of PyPDF2.generic via
__all__and to structure this big submodule more. I hope this makes it easier to test / expand in future if necessary. Smaller modules should have less merge conflicts.This PR should not change anything for users of PyPDF2.