Repository navigation
SVG: use the sRGB color of a paint with an ICC color - #2196
Merged
Merged
Conversation
SVG 1.1 allows an ICC color after an sRGB color, as Inkscape writes them, such as fill="#094491 icc-color(sRGB, 0.18, 0.28, 0.42)". This failed with ValueError; the sRGB color is now used, as in browsers.
andersonhc
approved these changes
Nov 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SVG 1.1 lets a paint give an ICC color after an sRGB color (https://www.w3.org/TR/SVG11/painting.html#SpecifyingPaint), and Inkscape writes them in color-managed documents, such as
stroke:#094491 icc-color(sRGB, 0.18046845, 0.27837034, 0.41960784)in the icon of Deluge.svgcolor()fails withValueError: ... could not be interpreted as a RGB(A) hex string, so the icons of Deluge and Open TV and the logo of stlite do not convert.Without color management the sRGB color is used, as browsers do, so
svgcolor()now drops a trailingicc-color(...). This coversfill,strokeand gradientstop-color.New cases in
parameters.pyandtest_gradient_stop_color_with_icc_colorfail without the change.