Repository navigation
Map the CSS Fonts 4 generic families to core fonts - #2180
Merged
andersonhc merged 3 commits intoNov 13, 2026
Merged
Conversation
font-family="system-ui", as in react-window's public/og.svg, failed with KeyError: No suitable font. system-ui, ui-sans-serif and ui-rounded now map to helvetica, ui-serif to times and ui-monospace to courier, as sans-serif, serif and monospace already do.
…milies # Conflicts: # CHANGELOG.md
andersonhc
approved these changes
Nov 13, 2026
# Conflicts: # CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
font-family="system-ui"fails withKeyError: No suitable font for family='system-ui'. The social preview imagepublic/og.svgof react-window uses it, as do bvaughn's other libraries.sans-serif,serifandmonospaceare already inFONT_FAMILY_ALIASES. This adds the generic families that CSS Fonts 4 introduced:system-ui,ui-sans-serifandui-roundedto helvetica,ui-serifto times, andui-monospaceto courier. It applies to SVG text andwrite_html(), which both useresolve_font_family().test_resolve_font_family_css_generic_familiescovers the five families; all fail without the change.