Repository navigation
SVG: size a root <svg> with width or height auto like one without - #2174
Merged
Merged
Conversation
Figma writes width="auto" height="auto" with a viewBox, as in the country flags of the ProtonVPN apps; it failed with ValueError: Unable to parse 'auto' as a length.
# Conflicts: # CHANGELOG.md
# Conflicts: # CHANGELOG.md
# Conflicts: # CHANGELOG.md
andersonhc
approved these changes
Nov 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Figma exports write
width="auto" height="auto"on the root<svg>, with aviewBox. The country flags in the ProtonVPN apps are like that, for exampleproton/vpn/app/gtk/assets/icons/flags/jp.svgin ProtonVPN/proton-vpn-gtk-app:pdf.image()fails on them:autois now read like a missingwidthorheight, so the image is sized from itsviewBox. Withw=48it is 48×32, keeping the flag's 3:2 ratio. Reading it as100%would give 50×50 there.test_document_size_autocovers both attributes, uppercase and padded with spaces; it fails without the change.